Skip to content

Conversation

@DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Dec 30, 2025

Because the rootlesscontainers/PRoot fork has long been archived and I wanted to use it as part of the Apptainer SIF container build process, I have brought it up to date with the latest proot-me/proot upstream and created a new fork at apptainer/PRoot. This PR updates the reference to point to the new, current fork.

Alternatively, if I could become the owner of the archived rootlesscontainers/PRoot repository I would unarchive it, update it, and maintain the PRoot fork there. That would be my preference, and then I would delete the apptainer/PRoot fork and close this pull request.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 5f4e706 into rootless-containers:master Jan 9, 2026
1 check passed
@AkihiroSuda
Copy link
Member

Alternatively, if I could become the owner of the archived rootlesscontainers/PRoot repository I would unarchive it, update it, and maintain the PRoot fork there. That would be my preference, and then I would delete the apptainer/PRoot fork and close this pull request.

Thanks for the interest, SGTM

@cyphar WDYT?

@cyphar
Copy link
Member

cyphar commented Jan 11, 2026

Yeah, I can add you as a maintainer of the project.

@DrDaveD
Copy link
Contributor Author

DrDaveD commented Jan 12, 2026

Yeah, I can add you as a maintainer of the project.

Thanks, but it looks like that's not enough. I don't have the privileges to replace the main (that is, rootless-containers) branch nor to take it out of archive mode. Could you promote me to owner? The changes I need to make, including pulling in many commits from upstream, are for some reason not accepted as a pull request.

@DrDaveD DrDaveD deleted the updated-proot-fork branch January 12, 2026 14:55
@cyphar
Copy link
Member

cyphar commented Jan 12, 2026

Weird. I also already unarchived it though?

(FWIW, I would prefer that you merge in your version to preserve the commit history.)

@DrDaveD
Copy link
Contributor Author

DrDaveD commented Jan 13, 2026

I also already unarchived it though?

Oh right, so that was also why I didn't see a setting for that!

(FWIW, I would prefer that you merge in your version to preserve the commit history.)

I thought it would be cleaner to start from the upstream commit history and add back in the changes needed for the fork. That way it would be just a few commits different from upstream. I went ahead and anyway also made a PR, rootless-containers/PRoot#9, which does a merge of upstream and applies a couple more fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants